Fix nothing scheduled on session boundary #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonva
approved these changes
Sep 5, 2023
sandreim
reviewed
Sep 5, 2023
eskimor
commented
Sep 6, 2023
| @@ -606,7 +606,6 @@ impl<T: Config> AssignmentProvider<BlockNumberFor<T>> for Pallet<T> { | |||
| fn get_provider_config(_core_idx: CoreIndex) -> AssignmentProviderConfig<BlockNumberFor<T>> { | |||
| let config = <configuration::Pallet<T>>::config(); | |||
| AssignmentProviderConfig { | |||
| availability_period: config.paras_availability_period, | |||
There was a problem hiding this comment.
No point in having this per assignment provider as the values have been unified.
| } | ||
|
|
||
| /// An entry tracking a paras | ||
| #[derive(Clone, Encode, Decode, TypeInfo, PartialEq, RuntimeDebug)] |
There was a problem hiding this comment.
These types are only used internally, no need to expose them via primitives.
There was a problem hiding this comment.
Wonderful. Thanks for refactoring this and reducing the API surface.
| Error::<T>::InvalidAssignment | ||
| })?; | ||
| let group_vals = | ||
| group_validators(group_idx).ok_or_else(|| Error::<T>::InvalidGroupIndex)?; |
There was a problem hiding this comment.
Simplification that fell out from changing the type of scheduled.
|
|
||
| let time_out_at = |backed_in_number, availability_period| { |
There was a problem hiding this comment.
Don't duplicate time out logic, but use same function as the scheduler uses to avoid this to diverge from reality.
| }) | ||
| .collect(); | ||
|
|
||
| // This will overwrite only `Free` cores if the scheduler module is working as intended. |
There was a problem hiding this comment.
No longer true. Only worked with the None hack.
eskimor
added
the
T8-polkadot
rphmeier
approved these changes
Sep 6, 2023
ordian
added a commit
that referenced
this pull request
Sep 7, 2023
* master: (28 commits) Adds base benchmark for do_tick in broker pallet (#1235) zombienet: use another collator image for the slashing test (#1386) Prevent a fail prdoc check to block (#1433) Fix nothing scheduled on session boundary (#1403) GHW for building and publishing docker images (#1391) pallet asset-conversion additional quote tests (#1371) Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226) Fix PRdoc check (#1419) Fix the wasm runtime substitute caching bug (#1416) Bump enumn from 0.1.11 to 0.1.12 (#1412) RFC 14: Improve locking mechanism for parachains (#1290) Add PRdoc check (#1408) fmt fixes (#1413) Enforce a decoding limit in MultiAssets (#1395) Remove dynamic dispatch using `Ext` (#1399) Remove redundant calls to `borrow()` (#1393) Get rid of polling in `WarpSync` (#1265) Bump actions/checkout from 3 to 4 (#1398) Bump thiserror from 1.0.47 to 1.0.48 (#1396) Move Relay-Specific Shared Code to One Place (#1193) ...
Ank4n
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Fix scheduled state at session boundaries. * Cleanup + better docs. * More cleanup and fixes. * Remove 12s hack. * Add dep. * Make clippy happy --------- Co-authored-by: eskimor <eskimor@no-such-url.com>
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Fix scheduled state at session boundaries. * Cleanup + better docs. * More cleanup and fixes. * Remove 12s hack. * Add dep. * Make clippy happy --------- Co-authored-by: eskimor <eskimor@no-such-url.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Same issue but about av-cores was fixed in #1403 Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We clear out claim queues at the end of the session. This leads to nodes not seeing anything scheduled for the next block. This is fixed by explicitly updating the claim queues in the
availability_coresruntime API.This ended up including a few further fixes and cleanups. Code is still not clean, but cleaner.