Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix worker binaries could not be found #1198

Merged
merged 5 commits into from
Aug 28, 2023
Merged

ci: fix worker binaries could not be found #1198

merged 5 commits into from
Aug 28, 2023

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Aug 28, 2023 •
edited
Loading

It seems that some of the changes in polkadot have not been migrated to polkadot-sdk, so the generated docker images fail to start, fix this by porting the changes in scripts directory that were present in: paritytech/polkadot#7337

Fixes: #1197

TODO

  • Test in Versi the image starts

@alexggh
ci: fix worker binaries could not be found
834087c 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@paritytech-ci paritytech-ci requested review from a team August 28, 2023 06:48
@alexggh alexggh mentioned this pull request Aug 28, 2023
Closed
@alexggh
Add missing bits
dc4d05b 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@paritytech-ci paritytech-ci requested a review from a team August 28, 2023 07:31
@alexggh
Fix malus build
8f4e0a3 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Copy link
Contributor Author

alexggh commented Aug 28, 2023

Tested in Versi the image starts now.

mrcnski
mrcnski reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the build stuff is duplicated in the polkadot/ directory, e.g. .gitlab/pipeline/build.yml and polkadot/.gitlab/pipeline/build.yml. The more up-to-date ones seem to be in the polkadot directory. Is it supposed to be like this? 🤔

@alvicsam
Copy link
Contributor

Is it supposed to be like this?

No, we just haven't cleaned it up yet.

@alexggh
Copy link
Contributor Author

alexggh commented Aug 28, 2023

Is it supposed to be like this?

No, we just haven't cleaned it up yet.

@alvicsam How would you prefer to handle this, should I close this PR and you handle it on cleanup ? Ideally, we wouldn't want to keep this functionality broken for too long, but I also I'm not 100% sure if there are other things that weren't ported yet.

@alvicsam
Copy link
Contributor

You've already finished it so I'd prefer to merge this one since it's urgent

@alexggh alexggh added the R0-silent Changes should not be mentioned in any release notes label Aug 28, 2023
@alexggh alexggh enabled auto-merge (squash) August 28, 2023 10:54
@alexggh alexggh merged commit 4252e48 into master Aug 28, 2023
3 of 4 checks passed
@alexggh alexggh deleted the alexaggh/fix_docker_image branch August 28, 2023 11:51
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
@alexggh @alvicsam @Daanvdplas
ci: fix worker binaries could not be found (#1198)
c8ac333 
* ci: fix worker binaries could not be found

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>

* Add missing bits

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>

* Fix malus build

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
e9fc9f4 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
090c53b 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
1d3b7c0 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
fc107e9 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
8fe3fcd 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
1d60655 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
22a513a 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
87a977b 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
adb160b 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
8b48f7c 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
2c08036 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@fewensa @serban300
Custom relay strategy (paritytech#1198)
b5c1482 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@fewensa @bkchr
Custom relay strategy (#1198)
1920117 
* Add relayer strategy

* Add default relayer strategy

* default relayer strategy

* expose relayer strategy

* fix compile

* fix compile

* docs

* Rename Relayer to Relay, keep RelayerDecide

* split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy`

* Remove relayer mode

* Remove unused import

* Rename `RelayerStrategy` to `RelayStrategy`

* Add missing docs

* clippy

* clippy

* clippy

* clippy

* Revert `relayer_mode` and add `MixStrategy`

* Add `EnforcementStrategy`

* fix bug and simplify relay strategy

* Update message_lane_loop.rs

* Update messages_target.rs

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* clippy

* fix test

* fix test

* test

test

test

fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcnski mrcnski mrcnski approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@acatangiu acatangiu acatangiu approved these changes

@alvicsam alvicsam alvicsam approved these changes

@sandreim sandreim sandreim approved these changes

@lexnv lexnv lexnv approved these changes

@sergejparity sergejparity sergejparity approved these changes

@mateo-moon mateo-moon mateo-moon approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

paritypr/polkadot-debug: Fails to start on versi
9 participants
@alexggh @alvicsam @mrcnski @EgorPopelyaev @acatangiu @sandreim @lexnv @sergejparity @mateo-moon