Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide: remove outdated references to jobs #739

Open
ordian opened this issue Jan 9, 2023 · 4 comments · May be fixed by paritytech/polkadot#7067
Open

guide: remove outdated references to jobs #739

ordian opened this issue Jan 9, 2023 · 4 comments · May be fixed by paritytech/polkadot#7067
Labels
T11-documentation This PR/Issue is related to documentation.

Comments

@ordian
Copy link
Member

ordian commented Jan 9, 2023

See paritytech/polkadot#4259 for the context why util::jobs was removed.

Outdated guide page: https://paritytech.github.io/polkadot/book/node/subsystems-and-jobs.html.

https://github.com/paritytech/polkadot/blob/master/roadmap/implementers-guide/src/node/subsystems-and-jobs.md
@mrcnski
Copy link
Contributor

mrcnski commented Feb 6, 2023 •
edited
Loading

I see some references to jobs on this page as well:

https://paritytech.github.io/polkadot/book/node/overseer.html#communication-between-subsystems

Edit: another one: https://paritytech.github.io/polkadot/book/node/backing/candidate-backing.html#functionality ("Candidate Backing Jobs"). I'll stop there; we'll need to be careful to rg and catch all references throughout the guide.

@daredevil3435
Copy link

Can I contribute? Don't assign me but I want to give it a try. Can you explain what exactly needs to be done?

@mrcnski
Copy link
Contributor

mrcnski commented Feb 26, 2023

Can I contribute? Don't assign me but I want to give it a try. Can you explain what exactly needs to be done?

Sorry for the late reply. Thanks for wanting to contribute!

I think you can start by removing the references to jobs that have been noted in this issue. For example, in the subsystems-and-jobs.md file you would need to remove "jobs" from the title as well as remove one of the paragraphs describing jobs. If you ctrl+F there are a couple sentences that should also be removed. Don't worry about doing a perfect job, the reviewers will help you. Is that enough to get you started? 🙂

@daredevil3435
Copy link

Can I contribute? Don't assign me but I want to give it a try. Can you explain what exactly needs to be done?

Sorry for the late reply. Thanks for wanting to contribute!

I think you can start by removing the references to jobs that have been noted in this issue. For example, in the subsystems-and-jobs.md file you would need to remove "jobs" from the title as well as remove one of the paragraphs describing jobs. If you ctrl+F there are a couple sentences that should also be removed. Don't worry about doing a perfect job, the reviewers will help you. Is that enough to get you started? 🙂

Yes. Thank you for explaining I'll start working on it. 🙂

@daredevil3435 daredevil3435 linked a pull request Apr 13, 2023 that will close this issue
Open
@mrcnski mrcnski mentioned this issue Apr 20, 2023
Merged
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added T11-documentation This PR/Issue is related to documentation. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T8-parachains_engineering and removed I7-documentation labels Aug 25, 2023
claravanstaden added a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@claravanstaden
Adds Rustfmt to Github Actions workflow and format files (paritytech#739
c16aa0d 
)

* Remove trailing whitespaces.

* Adds simple action.

* Provide manifest path

* Use nightly for fmt

* Test separate fmt job

* Removes fmt from check job.

* Fix toolchain.

* USe run command directly.

* Fix path

* Test if catches fmt issue

* Use cargo fmt command instead

* Use cargo actions

* Adds flag

* Cleanup

* Fix formatting

* Fmt changes

* Adds --check flag to rustfmt so Github Actions fail when file is not formatted. Added an unformatted file to test this.

* Reverts file imports used to test fmt.

Co-authored-by: claravanstaden <Cats 4 life!>
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@nanocryk
Geth pool error formatter (paritytech#739)
083c073 
* pool error formatter

* fix tests and clippy

* toml fmt

* remove InsufficientFundsForTransfer

* update test and better format unknown error

* fmt

* update test
@ggwpez ggwpez removed the C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. label Feb 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
3575ccd 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
c1e9ace 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
5f9affb 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
fdccbb6 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
51631fe 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
db34ac1 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
b80af56 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
427e3b1 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
7b4e892 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
99cc789 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
8d184db 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @adoerr @serban300
Change SS58Prefixes (paritytech#739)
e646afc 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
bkchr pushed a commit that referenced this issue Apr 10, 2024
@tomusdrw @adoerr @bkchr
Change SS58Prefixes (#739)
e8b5a53 
* Workaround for SS58Prefix issues in the UI.

* Change prefixes.

Co-authored-by: adoerr <0xad@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T11-documentation This PR/Issue is related to documentation.
Projects
parachains team board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed references to jobs in few files daredevil3435/polkadot
5 participants
@ordian @mrcnski @ggwpez @daredevil3435 @the-right-joyce