Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approval-voting: experiment with batching signature checks #730

Open
sandreim opened this issue Jan 23, 2023 · 3 comments
Open

approval-voting: experiment with batching signature checks #730

sandreim opened this issue Jan 23, 2023 · 3 comments

Comments

@sandreim
Copy link
Contributor

We could additionally gain some performance by batching signature checks. Right now we check them individually by handling CheckAndImportAssignment and CheckAndImportApproval. We have to test if there are any significant gains by doing something like, buffering signature checks until reach a limit or N milliseconds have passed since we started buffering. This would play nicely with #731.

Another approach is to do the batching in approval-distribution but I am not really sure if this would be more effective.

@burdges
Copy link

burdges commented Jan 24, 2023

I vaguely recalled "batching" here does not mean "cryptographic batching" like I mentioned in #730?

@sandreim
Copy link
Contributor Author

Yep, it is actually not, but stacks with "cryptographic batching" as we scale up validator and parachain count. It's mostly about improving our architecture of processing approval voting gossip messages and slicing the CPU intensive work.

@burdges
Copy link

burdges commented Jul 29, 2023

cc paritytech/polkadot#7554

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
claravanstaden added a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
* Force type 2 eth transactions

* Adds lock file changes.

* Use import instead of require.
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
* Add BLOCK_TIMESTAMP config for ts-tests

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Add NODE_BINARY_NAME

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Improve test-balances

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Add RUNTIME_SPEC_NAME, RUNTIME_SPEC_VERSION, RUNTIME_IMPL_VERSION

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Use CHAIN_ID

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Improve test-revert-receipt

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Use camelCase

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Use tabs

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants