Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve XCM debuggability #644

Open
xlc opened this issue May 8, 2023 · 2 comments
Open

Improve XCM debuggability #644

xlc opened this issue May 8, 2023 · 2 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T6-XCM This PR/Issue is related to XCM.

Comments

@xlc
Copy link
Contributor

xlc commented May 8, 2023

Reopen for paritytech/polkadot#7079

I just spent many hours to debug an issue caused by XCM v3 -> v2 -> v3 dropped proof size from weights and it is just hard to debug.
Again, more logging will be helpful.

https://twitter.com/XiliangChen/status/1654320992712544261
@xlc
Copy link
Contributor Author

xlc commented May 8, 2023 •
edited
Loading

https://github.com/paritytech/polkadot/blob/eb8dee045a75db91b7f4cb6a187f0bdd5e92ab47/xcm/src/v2/mod.rs#L1051

This silently drop the proof size. It should log something if proof size is not zero.

@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/discussion-on-xcm-v2-v3-support/2796/2

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@alistair-singh
disable proof of work (paritytech#644)
41979b2
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@tgmichel
Add paritydb support for fc-db (paritytech#644)
8784248 
* Use `sc_client_db::DatabaseSource`

* Add `paritydb` support for `fc-db`

* Add default feature `db`

* Update purge subcommand

* fmt

* Support `DatabaseSource::Auto`

* Template runtime db weights

* runtime manual-seal feature with rocksdb

* Use `DatabaseSource` in test

* Bump test sleep

* fc-db default feature

* `parity-db` renaming

* Err instead panic
@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I4-refactor Code needs refactoring. labels Mar 13, 2024
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Mar 25, 2024
@xlc xlc mentioned this issue Apr 8, 2024
Open
@acatangiu acatangiu moved this to Next to pick up in Parity Roadmap Apr 8, 2024
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
fix log level (#644)
2cfd2e7
@acatangiu acatangiu mentioned this issue Oct 18, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T6-XCM This PR/Issue is related to XCM.
Projects
Parity Roadmap
Status: Next to pick up
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xlc @franciscoaguirre @ggwpez @Polkadot-Forum