Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

availability-recovery optimizations #605

Open
sandreim opened this issue Jul 4, 2023 · 4 comments
Open

availability-recovery optimizations #605

sandreim opened this issue Jul 4, 2023 · 4 comments

Comments

@sandreim
Copy link
Contributor

sandreim commented Jul 4, 2023

Related to paritytech/polkadot#7411 . We should look further for optimizations for encoding/reconstruction to/from chunks. For example paritytech/reed-solomon-novelpoly#2 or taking advantage of latest SIMD instruction sets.

@burdges
Copy link

burdges commented Jul 18, 2023

cc #598

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@sandreim
Copy link
Contributor Author

Adding https://github.com/AndersTrier/reed-solomon-simd to the options to explore

@ordian
Copy link
Member

ordian commented May 29, 2024

This will be a breaking change to the format, but it might be worth it - can be coordinated with node_features.

Also, while at it, we can also finally fix the merkle commitment to be a binary tree instead of complicated hexary trie.
All of this is done in https://github.com/paritytech/erasure-coding and the benches show a decent gain in encoding as all: https://gist.github.com/ordian/0af2822e20bf905d53410a48dc122fd0

@burdges
Copy link

burdges commented May 30, 2024

Ahh nice, it switches to reed-solomon-simd too. We observe a speed up like the one he claims? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Status: To do
Development

No branches or pull requests

3 participants