Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRAME] Dont emit Issued event with 0 balance #5942

Closed
ggwpez opened this issue Oct 6, 2024 · 0 comments · Fixed by #5946
Closed

[FRAME] Dont emit Issued event with 0 balance #5942

ggwpez opened this issue Oct 6, 2024 · 0 comments · Fixed by #5946
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 6, 2024

Issued(0) should not be emitted but am seeing quite a few here.

Screenshot 2024-10-06 at 22 54 31
@ggwpez ggwpez added D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Oct 6, 2024
@ShoyuVanilla ShoyuVanilla mentioned this issue Oct 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 7, 2024
@ShoyuVanilla
[FRAME] fix: Do not emit Issued { amount: 0 } event (#5946)
215252e 
closes #5942

Couldn't find any emissions of `Event::Issued` without amount check
other than in this PR.

Currently, we have;


https://github.com/paritytech/polkadot-sdk/blob/4bda956d2c635c3926578741a19fbcc3de69cbb8/substrate/frame/balances/src/impl_currency.rs#L212-L220

and


https://github.com/paritytech/polkadot-sdk/blob/4bda956d2c635c3926578741a19fbcc3de69cbb8/substrate/frame/balances/src/impl_currency.rs#L293-L306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FRAME] fix: Do not emit Issued { amount: 0 } event ffddw/polkadot-sdk
1 participant
@ggwpez