fatxpool: use tracing instead of log

[michalkucharczyk]

Generally it would be better to use the tracing log macros.
Originally posted by @bkchr in #4639 (comment)

[michalkucharczyk]

also:
#6405 (comment)

[dharjeezy]

can i get to work on this? @michalkucharczyk

[michalkucharczyk]

Yes.

[michalkucharczyk]

@dharjeezy

A comment on how I see this. In general all log::[debug|trace|info] macros shall be replaced with their tracing counterpart.

Please do not change levels, and text messages. If the message contains already contains some "value: {}" or "value= {}", it should be migrated to the field. Example:

polkadot-sdk/substrate/client/transaction-pool/src/fork_aware_txpool/fork_aware_txpool.rs

Lines 485 to 493 in 82117ad

	log::debug!(target: LOG_TARGET,
	"fatp::ready_at_light {} from {} before: {} to be removed: {} after: {} took:{:?}",
	at,
	best_view.at.hash,
	before_count,
	all_extrinsics.len(),
	after_count,
	start.elapsed()
	);

could be written more or less as the following:

tracing::debug!(target: LOG_TARGET,
	"fatp::ready_at_light",
	at,
	from = best_view.at.hash,
	before = before_count,
	to_be_removed = all_extrinsics.len(),
	after,
	took = start.elapsed()
);

You could start with a single file, and ping me when you think it is done. We will discuss if it is OK, or if any improvements are needed. Does it sound ok for you?

[michalkucharczyk]

One more thought.

On the trace level the logs for individual transactions are printed. They start with [0xHASH] prefix. Examples:

polkadot-sdk/substrate/client/transaction-pool/src/fork_aware_txpool/fork_aware_txpool.rs

Line 267 in 82117ad

log::trace!(target: LOG_TARGET, "[{:?}] fatp::dropped notification {:?}, removing", dropped_tx_hash,dropped.reason);

polkadot-sdk/substrate/client/transaction-pool/src/fork_aware_txpool/fork_aware_txpool.rs

Line 695 in 82117ad

log::trace!(target: LOG_TARGET, "[{:?}] fatp::submit_one views:{}", self.tx_hash(&xt), self.active_views_count());

and there is also macro that prints the iterator over transactions:

polkadot-sdk/substrate/client/transaction-pool/src/fork_aware_txpool/fork_aware_txpool.rs

Line 648 in 82117ad

log_xt_trace!(target: LOG_TARGET, xts.iter().map(|xt| self.tx_hash(xt)), "[{:?}] fatp::submit_at");

I think we should get rid of the prefix in this case use the hash as regular field, e.g. txhash. It shall be the same name for every debug event.

[dharjeezy]

Ok. Thank you for the clarifications.