Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new try-state check invariant for nomination-pools (points >= stake) #5448

Closed
gpestana opened this issue Aug 23, 2024 · 0 comments · Fixed by #5465
Closed

Add new try-state check invariant for nomination-pools (points >= stake) #5448

gpestana opened this issue Aug 23, 2024 · 0 comments · Fixed by #5465
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@gpestana
Copy link
Contributor

gpestana commented Aug 23, 2024 •
edited
Loading

Given the design of points to stake in nomination pools, there's a known invariant that is easy to check in the nomination pallet's try-state checks which is:

  • A pool's points can never be lower than the stake in the same pool.

Add a check for this invariant in the try-state checks of the nomination pools pallet.
@gpestana gpestana added the T2-pallets This PR/Issue is related to a particular pallet. label Aug 23, 2024
@Ank4n Ank4n added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Aug 23, 2024
@dharjeezy dharjeezy mentioned this issue Aug 26, 2024
Merged
@gpestana gpestana moved this from 📕 Backlog to ✂️ In progress. in (Nominated) Proof of Stake Aug 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 29, 2024
@dharjeezy @gpestana @Ank4n
Add new try-state check invariant for nomination-pools (points >= sta…
61bfcb8 
…ke) (#5465)

closes #5448

---------

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from ✂️ In progress. to ✅ Done in (Nominated) Proof of Stake Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T2-pallets This PR/Issue is related to a particular pallet.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new try-state check invariant for nomination-pools (points >= stake) dharjeezy/polkadot-sdk
2 participants
@gpestana @Ank4n