Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cumulus rpc: add chainspec API #5191

Closed
2 tasks done
niklasad1 opened this issue Jul 30, 2024 · 0 comments · Fixed by #5205
Closed
2 tasks done

cumulus rpc: add chainspec API #5191

niklasad1 opened this issue Jul 30, 2024 · 0 comments · Fixed by #5205
Assignees
@lexnv
Labels
I5-enhancement An additional feature request. T9-cumulus This PR/Issue is related to cumulus.

Comments

@niklasad1
Copy link
Member

niklasad1 commented Jul 30, 2024 •
edited
Loading

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

polkadot exposes the entire new rpc API including the chainspec API and the following rpc APIs are provided by polkadot but not cumulus:

diff polkadot.json polkadot_parachain.json
15,18d14
<             "babe_epochAuthorship",
<             "beefy_getFinalizedHead",
<             "beefy_subscribeJustifications",
<             "beefy_unsubscribeJustifications",
28,30d23
<             "chainSpec_v1_chainName",
<             "chainSpec_v1_genesisHash",
<             "chainSpec_v1_properties",
57,64d49
<             "grandpa_proveFinality",
<             "grandpa_roundState",
<             "grandpa_subscribeJustifications",
<             "grandpa_unsubscribeJustifications",
<             "mmr_generateProof",
<             "mmr_root",
<             "mmr_verifyProof",
<             "mmr_verifyProofStateless",
95d79
<             "sync_state_genSyncSpec",

Request

Cumulus should at least provide the chainspec RPC API

Solution

The chainspec stuff needs needs to enabled as rpc extension here, it looks like the code needs to refactoring to access the chainspec though if possible...

Are you willing to help with this request?

Yes!
@niklasad1 niklasad1 added I5-enhancement An additional feature request. T9-cumulus This PR/Issue is related to cumulus. labels Jul 30, 2024
@lexnv lexnv self-assigned this Jul 31, 2024
@lexnv lexnv mentioned this issue Aug 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2024
@lexnv
rpc: Enable ChainSpec for polkadot-parachain (#5205)
ce6938a 
This PR enables the `chainSpec_v1` class for the polkadot-parachian. 
The chainSpec is part of the rpc-v2 which is spec-ed at:
https://github.com/paritytech/json-rpc-interface-spec/blob/main/src/api/chainSpec.md.

This also paves the way for enabling a future `chainSpec_unstable_spec`
on all nodes.

Closes: #5191

cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexnv lexnv

Labels
I5-enhancement An additional feature request. T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: Enable ChainSpec for polkadot-parachain paritytech/polkadot-sdk
2 participants
@niklasad1 @lexnv