Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet assets start_destroy() invalid doc comment or bug #5184

Closed
Daanvdplas opened this issue Jul 30, 2024 · 0 comments · Fixed by #5204
Closed

pallet assets start_destroy() invalid doc comment or bug #5184

Daanvdplas opened this issue Jul 30, 2024 · 0 comments · Fixed by #5204

Comments

@Daanvdplas
Copy link
Contributor

The comment above the dispatchable start_destroy which implies that the asset should be frozen in order to start destroying the asset, is not true. Either this comment should be removed or there is a bug.
@gui1117 gui1117 mentioned this issue Aug 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 16, 2024
@gui1117 @bkchr @ggwpez
Fix doc: start_destroy doesn't need asset to be frozen (#5204)
fd522b8 
Fix #5184

`owner` can set himself as a `freezer` and freeze the asset so
requirement is not really needed. And requirement is not implemented.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix doc: start_destroy doesn't need asset to be frozen gui1117/polkadot-sdk
1 participant
@Daanvdplas