Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update polkadot CPU score to reflect 8 cores are minimum required #5122

Closed
3 tasks done
alexggh opened this issue Jul 24, 2024 · 3 comments · Fixed by #5127
Closed
3 tasks done

Update polkadot CPU score to reflect 8 cores are minimum required #5122

alexggh opened this issue Jul 24, 2024 · 3 comments · Fixed by #5127
Assignees
@alexggh
Labels
T0-node This PR/Issue is related to the topic “node”.

Comments

@alexggh
Copy link
Contributor

alexggh commented Jul 24, 2024 •
edited
Loading

Full context of the discussion is here https://forum.polkadot.network/t/rfc-increasing-recommended-minimum-core-count-for-reference-hardware/8156, long story short the minimum required core count for validators need to be increased from 4 to 8 to increase the overall capacity for PVF execution, to fully take advantage of async backing.

The feedback from validators have been overwhelming positive, so as a first step we need to modify the CPU score benchmark to reflect this changes and inform validators at startup that in the future this will become the norm.

Note!! This should not do any enforcements at this moment it should be just to inform validator that they are not meeting this requirements and they need to take the necessary steps to increase their capacity.

TODO
@alexggh alexggh added the T0-node This PR/Issue is related to the topic “node”. label Jul 24, 2024
@alexggh alexggh self-assigned this Jul 24, 2024
@ggwpez
Copy link
Member

ggwpez commented Jul 24, 2024

Whatever you change, please keep the polkadot Wiki in sync: https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#reference-hardware

@alexggh
Copy link
Contributor Author

alexggh commented Jul 24, 2024

Whatever you change, please keep the polkadot Wiki in sync: https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#reference-hardware

Yes, definitely.

@alexggh alexggh mentioned this issue Jul 24, 2024
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue Sep 5, 2024
@alexggh
Add benchmark for the number of minimum cpu cores (#5127)
a947cb8 
Fixes: #5122.

This PR extends the existing single core `benchmark_cpu` to also build a
score of the entire processor by spawning `EXPECTED_NUM_CORES(8)`
threads and averaging their throughput.

This is better than simply checking the number of cores, because also
covers multi-tenant environments where the OS sees a high number of
available CPUs, but because it has to share it with the rest of his
neighbours its total throughput does not satisfy the minimum
requirements.


## TODO
- [x] Obtain reference values on the reference hardware.

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@github-project-automation github-project-automation bot moved this from Backlog to Completed in parachains team board Sep 5, 2024
@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/rfc-increasing-recommended-minimum-core-count-for-reference-hardware/8156/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexggh alexggh

Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add benchmark for the number of minimum cpu cores paritytech/polkadot-sdk
3 participants
@ggwpez @alexggh @Polkadot-Forum