Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move block announce validation/polling to SyncingEngine #503

Closed
Tracked by #534
dmitry-markin opened this issue Jun 14, 2023 · 0 comments · Fixed by #1170 · May be fixed by paritytech/substrate#14675
Closed
Tracked by #534

Move block announce validation/polling to SyncingEngine #503

dmitry-markin opened this issue Jun 14, 2023 · 0 comments · Fixed by #1170 · May be fixed by paritytech/substrate#14675
Assignees
@dmitry-markin
Labels
I4-refactor Code needs refactoring.

Comments

@dmitry-markin
Copy link
Contributor

Move block announce validation/polling from ChainSync to SyncingEngine.

This issue is a part of Sync 2.0 (#534) preparation work aimed at making ChainSync a pure state machine.
@dmitry-markin dmitry-markin self-assigned this Jun 14, 2023
@arkpar arkpar mentioned this issue Aug 24, 2023
Open
@dmitry-markin dmitry-markin mentioned this issue Jul 28, 2023
Open
@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. and removed I7-refactor labels Aug 25, 2023
@dmitry-markin dmitry-markin mentioned this issue Aug 25, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress 🛠 to Blocked ⛔️ in Networking Sep 4, 2023
@altonen altonen moved this from Blocked ⛔️ to Done ✅ in Networking Jan 2, 2024
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @HCastano @bkchr
Chain specific message lane apis (#503)
53791a1 
* replace generic message lane APIs with chain-specific

* moved SubstrateHeadersSyncPipeline to headers_pipeline.rs

* substrate-specific message lane trait

* Update relays/substrate/src/messages_lane.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-markin dmitry-markin

Labels
I4-refactor Code needs refactoring.
Projects
Networking
Status: Done ✅
Milestone
No milestone
2 participants
@dmitry-markin @the-right-joyce