Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRV2: Missing pallet index causes misleading error message #4552

Closed
kianenigma opened this issue May 23, 2024 · 0 comments · Fixed by #4643
Closed

CRV2: Missing pallet index causes misleading error message #4552

kianenigma opened this issue May 23, 2024 · 0 comments · Fixed by #4643
Assignees
@gupnik

Comments

@kianenigma
Copy link
Contributor

When I removed all pallet indices in mod runtime to see if it is supported or not, I get:

error: `System` pallet declaration is missing. Please add this line: `pub type System = frame_system;`
    --> /home/kian/remote-builds/polkadot-sdk_minimal-template/runtime/src/lib.rs:96:5
     |
  96 | mod runtime {
     |     ^^^^^^^

I think it is a good choice to no longer support implicit indices, but the error message should be improve.
@gupnik gupnik mentioned this issue May 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 2, 2024
@codekitz @bkchr
Better error for missing index in CRV2 (#4643)
f81751e 
Fixes #4552

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <info@kchr.de>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Jun 2, 2024
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
@codekitz @bkchr @hitchhooker
Better error for missing index in CRV2 (paritytech#4643)
a528609 
Fixes paritytech#4552

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <info@kchr.de>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@codekitz @bkchr @TarekkMA
Better error for missing index in CRV2 (paritytech#4643)
6166d09 
Fixes paritytech#4552

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <info@kchr.de>
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this issue Dec 27, 2024
@codekitz @bkchr
Better error for missing index in CRV2 (paritytech#4643)
0a731eb 
Fixes paritytech#4552

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <info@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gupnik gupnik

Labels
None yet
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better error for missing index in CRV2 paritytech/polkadot-sdk
2 participants
@kianenigma @gupnik