Pass warp sync target block to parachain node's SyncingEngine
during initialization
#3537
Labels
I3-annoyance
The node behaves within expectations, however this “expected behaviour” itself is at issue.
Currently, warp sync target block header is passed to parachain node syncing via oneshot channel, which is later polled in
SyncingEngine
:polkadot-sdk/substrate/client/network/sync/src/engine.rs
Lines 659 to 667 in 6508866
and passed all the way down to
WarpSync
:polkadot-sdk/substrate/client/network/sync/src/strategy/warp.rs
Lines 290 to 301 in 6508866
This is cumbersome, requires checks for the correct phase of syncing, leads to bugs like #3496, and should be reworked to pass the target block header as a parameter during the initialization of
SyncingEngine
.The text was updated successfully, but these errors were encountered: