Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update benchmarks for Scheduler on_initialize #344

Closed
shawntabrizi opened this issue Sep 18, 2020 · 1 comment
Closed

Update benchmarks for Scheduler on_initialize #344

shawntabrizi opened this issue Sep 18, 2020 · 1 comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@shawntabrizi
Copy link
Member

The Scheduler pallet manually tracks the read/writes when triggering the on_initialize part of the pallet.

This means that an external party cannot influence the weight of this function/process. It we should look to improve the on_initialize benchmarks such that the generated function can be used for weights, and then be manipulated through the WeightInfo struct.
@shawntabrizi shawntabrizi mentioned this issue Sep 18, 2020
Merged
@gui1117 gui1117 mentioned this issue Sep 21, 2020
Merged
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
@ggwpez
Copy link
Member

ggwpez commented Nov 30, 2023

Its using proper benchmarking now.

@ggwpez ggwpez closed this as completed Nov 30, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Nov 30, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@musnit
fix node script (paritytech#344)
28489b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shawntabrizi @juangirini @ggwpez @the-right-joyce