Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce the check-new-bootnode workflow #1716

Open
PierreBesson opened this issue Sep 26, 2023 · 0 comments
Open

Reintroduce the check-new-bootnode workflow #1716

PierreBesson opened this issue Sep 26, 2023 · 0 comments
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@PierreBesson
Copy link

PierreBesson commented Sep 26, 2023

This workflow is no longer active since the migration to the polkadot-sdk. Althought, it is still present in the present in repo under polkadot/.github/workflows/check-new-bootnodes.yml but doesn't do anything. It is relying on the check_new_bootnodes.sh which was present in the old paritech/polkadot repo but I can no longer find it in the monorepo.

This script is very useful to check the validity of new bootnodes introduced. Invalid bootnodes were submitted multiple times in the past and this served as a good sanity check for our bootnode lists.
Moreover, this would allow us to also check the validity of proposed system parachain bootnodes in PRs.

@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Sep 26, 2023
bkchr pushed a commit that referenced this issue Apr 10, 2024
* Remove SOURCE_PARACHAIN_PARA_ID

Remove SubstrateParachainsPipeline::SOURCE_PARACHAIN_PARA_ID

* Avoid duplicate ChainBase and ParachainBase implementations

* Replace ChainShadow with UnderlyingChainProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Development

No branches or pull requests

1 participant