ensure xcm outcome is always complete

polkadot/xcm/pallet-xcm/src/lib.rs

@@ -302,7 +302,12 @@ pub mod pallet {
 				hash,
 				max_weight,
 				max_weight,
-			);
+			)
+			.ensure_complete()
+			.map_err(|error| {
+				log::error!(target: "runtime::xcm", "Failed execute transfer message with {:?}", error);
+				Error::<T>::LocalExecutionIncomplete
+			})?;
 			Self::deposit_event(Event::Attempted { outcome: outcome.clone() });
 			Ok(outcome)
 		}
@@ -1495,9 +1500,9 @@ impl<T: Config> Pallet<T> {
 		let outcome =
 			T::XcmExecutor::execute_xcm_in_credit(origin, local_xcm, hash, weight, weight);
 		Self::deposit_event(Event::Attempted { outcome: outcome.clone() });
-		if let Some(remote_xcm) = remote_xcm {
-			outcome.ensure_complete().map_err(|_| Error::<T>::LocalExecutionIncomplete)?;
+		outcome.ensure_complete().map_err(|_| Error::<T>::LocalExecutionIncomplete)?;
 
+		if let Some(remote_xcm) = remote_xcm {
 			let (ticket, price) = validate_send::<T::XcmRouter>(dest, remote_xcm.clone())
 				.map_err(Error::<T>::from)?;
 			if origin != Here.into_location() {

polkadot/xcm/procedural/tests/ui.rs

@@ -21,7 +21,7 @@
 fn ui() {
 	// Only run the ui tests when `RUN_UI_TESTS` is set.
 	if std::env::var("RUN_UI_TESTS").is_err() {
-		return;
+		return
 	}
 
 	// As trybuild is using `cargo check`, we don't need the real WASM binaries.

substrate/client/chain-spec/src/chain_spec.rs

@@ -785,7 +785,7 @@ fn json_eval_value_at_key(
 	fun: &dyn Fn(&json::Value) -> bool,
 ) -> bool {
 	let Some(key) = path.pop_front() else {
-		return false;
+		return false
 	};
 
 	if path.is_empty() {

substrate/client/rpc-spec-v2/src/chain_head/subscription/inner.rs

@@ -763,7 +763,7 @@ impl<Block: BlockT, BE: Backend<Block>> SubscriptionsInner<Block, BE> {
 		// blocks.
 		for hash in hashes.clone() {
 			if !sub.contains_block(hash) {
-				return Err(SubscriptionManagementError::BlockHashAbsent);
+				return Err(SubscriptionManagementError::BlockHashAbsent)
 			}
 		}
 

substrate/frame/system/src/tests.rs

@@ -788,7 +788,7 @@ fn last_runtime_upgrade_spec_version_usage() {
 			// a runtime upgrade in the pipeline of being applied, you should use the spec version
 			// of this upgrade.
 			if System::last_runtime_upgrade_spec_version() > 1337 {
-				return Weight::zero();
+				return Weight::zero()
 			}
 
 			// Do the migration.

substrate/primitives/core/src/address_uri.rs

@@ -184,7 +184,7 @@ impl<'a> AddressUri<'a> {
 					Error::in_pass(initial_input, initial_input_len - input.len())
 				} else {
 					Error::in_phrase(initial_input, initial_input_len - input.len())
-				});
+				})
 			}
 		}
 

substrate/primitives/core/src/crypto.rs

@@ -434,7 +434,7 @@ impl<T: Sized + AsMut<[u8]> + AsRef<[u8]> + Public + Derive> Ss58Codec for T {
 	fn from_string(s: &str) -> Result<Self, PublicError> {
 		let cap = AddressUri::parse(s)?;
 		if cap.pass.is_some() {
-			return Err(PublicError::PasswordNotAllowed);
+			return Err(PublicError::PasswordNotAllowed)
 		}
 		let s = cap.phrase.unwrap_or(DEV_ADDRESS);
 		let addr = if let Some(stripped) = s.strip_prefix("0x") {
@@ -454,7 +454,7 @@ impl<T: Sized + AsMut<[u8]> + AsRef<[u8]> + Public + Derive> Ss58Codec for T {
 	fn from_string_with_version(s: &str) -> Result<(Self, Ss58AddressFormat), PublicError> {
 		let cap = AddressUri::parse(s)?;
 		if cap.pass.is_some() {
-			return Err(PublicError::PasswordNotAllowed);
+			return Err(PublicError::PasswordNotAllowed)
 		}
 		let (addr, v) = Self::from_ss58check_with_version(cap.phrase.unwrap_or(DEV_ADDRESS))?;
 		if cap.paths.is_empty() {

substrate/utils/wasm-builder/src/wasm_project.rs

@@ -916,7 +916,7 @@ fn generate_rerun_if_changed_instructions(
 	while let Some(dependency) = dependencies.pop() {
 		// Ignore all dev dependencies
 		if dependency.kind == DependencyKind::Development {
-			continue;
+			continue
 		}
 
 		let path_or_git_dep =