Fix unchecked extrinsic signing in tests

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
paritytech · Mar 8, 2024 · 6fd6b25 · 6fd6b25
1 parent 611c165
commit 6fd6b25
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 17 deletions.
diff --git a/substrate/bin/node/testing/src/bench.rs b/substrate/bin/node/testing/src/bench.rs
@@ -574,13 +574,7 @@ impl BenchKeyring {
 					genesis_hash,
 				);
 				let key = self.accounts.get(&signed).expect("Account id not found in keyring");
-				let signature = payload.using_encoded(|b| {
-					if b.len() > 256 {
-						key.sign(&blake2_256(b))
-					} else {
-						key.sign(b)
-					}
-				});
+				let signature = payload.using_encoded(|b| key.sign(&blake2_256(b)));
 				UncheckedExtrinsic {
 					preamble: Preamble::Signed(
 						sp_runtime::MultiAddress::Id(signed),

diff --git a/substrate/bin/node/testing/src/keyring.rs b/substrate/bin/node/testing/src/keyring.rs
@@ -100,16 +100,7 @@ pub fn sign(
 			let payload =
 				(xt.function, tx_ext.clone(), spec_version, tx_version, genesis_hash, genesis_hash);
 			let key = AccountKeyring::from_account_id(&signed).unwrap();
-			let signature =
-				payload
-					.using_encoded(|b| {
-						if b.len() > 256 {
-							key.sign(&blake2_256(b))
-						} else {
-							key.sign(b)
-						}
-					})
-					.into();
+			let signature = payload.using_encoded(|b| key.sign(&blake2_256(b))).into();
 			UncheckedExtrinsic {
 				preamble: sp_runtime::generic::Preamble::Signed(
 					sp_runtime::MultiAddress::Id(signed),