Skip to content

Commit

Permalink
polkadot-parachain: Remove shell node (#5911)
Browse files Browse the repository at this point in the history
Removing the shell node variant for the polkadot-parachain as discussed
here:
#5586 (comment)

Resolves #5898
  • Loading branch information
serban300 authored Oct 4, 2024
1 parent a995caf commit 261b3da
Show file tree
Hide file tree
Showing 23 changed files with 21 additions and 1,629 deletions.
16 changes: 1 addition & 15 deletions .github/workflows/check-cargo-check-runtimes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,25 +85,11 @@ jobs:
with:
root: cumulus/parachains/runtimes/contracts

check-runtime-starters:
runs-on: ${{ needs.preflight.outputs.RUNNER }}
container:
image: ${{ needs.preflight.outputs.IMAGE }}
needs: [check-runtime-assets, preflight]
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Run cargo check
uses: ./.github/actions/cargo-check-runtimes
with:
root: cumulus/parachains/runtimes/starters

check-runtime-testing:
runs-on: ${{ needs.preflight.outputs.RUNNER }}
container:
image: ${{ needs.preflight.outputs.IMAGE }}
needs: [check-runtime-starters, preflight]
needs: [preflight]
timeout-minutes: 20
steps:
- name: Checkout
Expand Down
13 changes: 2 additions & 11 deletions .gitlab/pipeline/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ build-test-parachain:
# DAG: build-runtime-assets -> build-runtime-collectives -> build-runtime-bridge-hubs
# DAG: build-runtime-assets -> build-runtime-collectives -> build-runtime-contracts
# DAG: build-runtime-assets -> build-runtime-coretime
# DAG: build-runtime-assets -> build-runtime-starters -> build-runtime-testing
# DAG: build-runtime-assets -> build-runtime-testing
build-runtime-assets:
<<: *build-runtime-template
variables:
Expand Down Expand Up @@ -298,22 +298,13 @@ build-runtime-contracts:
- job: build-runtime-collectives
artifacts: false

build-runtime-starters:
<<: *build-runtime-template
variables:
RUNTIME_PATH: "cumulus/parachains/runtimes/starters"
# this is an artificial job dependency, for pipeline optimization using GitLab's DAGs
needs:
- job: build-runtime-assets
artifacts: false

build-runtime-testing:
<<: *build-runtime-template
variables:
RUNTIME_PATH: "cumulus/parachains/runtimes/testing"
# this is an artificial job dependency, for pipeline optimization using GitLab's DAGs
needs:
- job: build-runtime-starters
- job: build-runtime-assets
artifacts: false

build-short-benchmark-cumulus:
Expand Down
72 changes: 0 additions & 72 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ members = [
"cumulus/parachains/runtimes/glutton/glutton-westend",
"cumulus/parachains/runtimes/people/people-rococo",
"cumulus/parachains/runtimes/people/people-westend",
"cumulus/parachains/runtimes/starters/seedling",
"cumulus/parachains/runtimes/starters/shell",
"cumulus/parachains/runtimes/test-utils",
"cumulus/parachains/runtimes/testing/penpal",
"cumulus/parachains/runtimes/testing/rococo-parachain",
Expand Down Expand Up @@ -1187,7 +1185,6 @@ schnorrkel = { version = "0.11.4", default-features = false }
seccompiler = { version = "0.4.0" }
secp256k1 = { version = "0.28.0", default-features = false }
secrecy = { version = "0.8.0", default-features = false }
seedling-runtime = { path = "cumulus/parachains/runtimes/starters/seedling" }
separator = { version = "0.4.1" }
serde = { version = "1.0.210", default-features = false }
serde-big-array = { version = "0.3.2" }
Expand All @@ -1198,7 +1195,6 @@ serial_test = { version = "2.0.0" }
sha1 = { version = "0.10.6" }
sha2 = { version = "0.10.7", default-features = false }
sha3 = { version = "0.10.0", default-features = false }
shell-runtime = { path = "cumulus/parachains/runtimes/starters/shell" }
shlex = { version = "1.3.0" }
slot-range-helper = { path = "polkadot/runtime/common/slot_range_helper", default-features = false }
slotmap = { version = "1.0" }
Expand Down
1 change: 0 additions & 1 deletion cumulus/parachains/chain-specs/shell-head-data

This file was deleted.

38 changes: 0 additions & 38 deletions cumulus/parachains/chain-specs/shell.json

This file was deleted.

79 changes: 0 additions & 79 deletions cumulus/parachains/runtimes/starters/seedling/Cargo.toml

This file was deleted.

26 changes: 0 additions & 26 deletions cumulus/parachains/runtimes/starters/seedling/build.rs

This file was deleted.

Loading

0 comments on commit 261b3da

Please sign in to comment.