Just pass a folder to benchmark pallet --output
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
mordamax
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Praying 🙏 might help, although you can test by passing env variables which will override the pipeline-scripts reference to your branch
like this: /cmd queue -v PIPELINE_SCRIPTS_REF=oty-enable-instance-benchmarking -c bench-bot $ .......
Re. staging https://github.com/paritytech/ci_cd/issues/564
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for paritytech/substrate#12332
Changes for pallet benchmarking:
--output. FRAME should now generate a filename without::in it. This prevents multiple instance results being written to the same file, hence enabling instance benchmarking.--lockedto the bench command.Is there a staging deployment or do we just pray that it works after merge?