Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bench-bot infra docs #58

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Conversation

radupopa2010
Copy link
Contributor

No description provided.

@radupopa2010 radupopa2010 requested a review from a team as a code owner July 1, 2022 10:41
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link

@sergejparity sergejparity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix some spelling

@joao-paulo-parity joao-paulo-parity dismissed their stale review July 1, 2022 11:21

Review wasn't effective

@joao-paulo-parity joao-paulo-parity removed their request for review July 1, 2022 11:21
@joao-paulo-parity joao-paulo-parity merged commit 9a792b8 into master Jul 1, 2022
@joao-paulo-parity joao-paulo-parity deleted the add-bench-bot-infra-docs branch July 1, 2022 11:46
@joao-paulo-parity joao-paulo-parity restored the add-bench-bot-infra-docs branch July 1, 2022 11:46
@TriplEight
Copy link
Contributor

@radupopa2010 why did you resolve everything without applying the important and valid suggestions?

@radupopa2010
Copy link
Contributor Author

I did apply the suggestions and then resolved the conversation. It must have been some error and the suggestions were not applied

@TriplEight
Copy link
Contributor

it must've been because of github's issues last week

@joao-paulo-parity joao-paulo-parity deleted the add-bench-bot-infra-docs branch December 1, 2022 07:02
@joao-paulo-parity joao-paulo-parity restored the add-bench-bot-infra-docs branch December 1, 2022 07:02
@joao-paulo-parity joao-paulo-parity deleted the add-bench-bot-infra-docs branch December 1, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants