This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
make unsafe usages more safe #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the unsafe calls to
transmutecould be removed with a simpleascast.The unsafe casts from bytes to floats were actually wrong because they didn't mask out sNAN, which could lead to trap/UB when interpreting programs with carefully crafted constants. More discussion here: rust-lang/rust#39271
We should set a goal for 0 unsafe code within this crate: it should be possible once the methods in the above PR are stabilized.