Introduce CountedInput
. a wrapper which counts the number of bytes successfully read
#630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some code which tries to track the number of byte read with
remaining_len
. Butremaining_len
don't always give information.I think it is better to provide an accurate counter.
I used u64 because it made the code simpler. And more general purpose.
Otherwise I was thinking using a type:
and do the count in u32.
But most machine being 64bit, I think it should execute good.