Disable cache if explicit memory budget=0 passed #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Feb 9, 2020
NikVolf
commented
Feb 10, 2020
| @@ -236,7 +236,7 @@ impl MallocSizeOf for DBAndColumns { | |||
| fn size_of(&self, ops: &mut parity_util_mem::MallocSizeOfOps) -> usize { | |||
| let mut total = self.column_names.size_of(ops) | |||
| // we have at least one column always, so we can call property on it | |||
| + self.static_property_or_warn(0, "rocksdb.block-cache-usage"); | |||
There was a problem hiding this comment.
this actually produces warning when block cache is disabled 🤷♀️
niklasad1
changed the title
NikVolf
force-pushed
the
nv-rocksdb-zero-cache
branch
from
1ae3b23 to
5876070
Compare
ordian
added a commit
that referenced
this pull request
Feb 13, 2020
* master: prepare rlp-derive release (#344) Update/change licenses: MIT/Apache2.0 (#342) rlp-derive extracted (#343) Format for readme and changelog corrected (#341) Parity runtime moved to parity common for publication in crates.io (#271) Disable cache if explicit memory budget=0 passed (#339) [parity-crypto] prepare 0.5.0 (#336) [parity crypto]: remove unused depend `rustc_hex` (#337) Update doc comment (#335)
ordian
added a commit
that referenced
this pull request
Mar 6, 2020
* master: kvdb-rocksdb: bump version (#348) kvdb-rocksdb: expose RocksDB stats (#347) Implement Error for FromDecStrErr (#346) Fix clippy lints for rlp-derive (#345) prepare rlp-derive release (#344) Update/change licenses: MIT/Apache2.0 (#342) rlp-derive extracted (#343) Format for readme and changelog corrected (#341) Parity runtime moved to parity common for publication in crates.io (#271) Disable cache if explicit memory budget=0 passed (#339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to create LRUCache cache and set other cache options if user want low memory profile and thus no cache!
Also fixes #330