Use "impl-trait-for-tuples" for tuples in parity-util-mem #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
force-pushed
the
nv-derive-tuples
branch
from
79c5b24 to
5cdc4a0
Compare
bkchr
approved these changes
Jan 2, 2020
| fn size_of(&self, ops: &mut MallocSizeOfOps) -> usize { | ||
| self.0.size_of(ops) + self.1.size_of(ops) + self.2.size_of(ops) + self.3.size_of(ops) | ||
| let mut result = 0; | ||
| for_tuples!( #( result += Tuple.size_of(ops); )* ); |
There was a problem hiding this comment.
The full function can be written like:
for_tuples!( #( Tuple.size_of(ops) )+* )
There was a problem hiding this comment.
This is first what I tried - does not work, probably because of () variant is also expanded, producing () return value
There was a problem hiding this comment.
Ahh yeah. Do we need the () case? If not impl_for_tuple(1, 12)
ordian
approved these changes
Jan 2, 2020
dvdplm
added a commit
that referenced
this pull request
Jan 14, 2020
* master: (27 commits) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) extract common kvdb tests into a crate (#301) Expose to_hex and from_hex from impl-serde (#302) Add a top level function to parity-util-mem (#298) I/O statistic for key-value databases (#294) use for_tuples (#300) Add memory extensions for LRUCache, hashbrown (#293) Add memory stats for kvdb-s (#292) Provide #[derive(MallocSizeOf)] that is actually working (#291) Move and extend impls for locking primitives (#290) Update uint README (#288) Update README.md (#287) [ci]: remove feature flags in virtual workspace (#289) Prepare releases (#286) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.