[keccak-hash] Add no_std support, migrate to 2018 edition #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate keccak-hash to 2018 edition; Replace H256 with [u8; 32] Signed-off-by: koushiro <koushiro.cqx@gmail.com>
dvdplm
previously requested changes
Jun 6, 2019
There was a problem hiding this comment.
Changing the return type here and disentangle the crate from ethereum-types has massive consequences for consuming code. It is going to take us a long while to go through and update all the rest. I think it would be a good idea to revert that change and add a new PR with just that change (alternatively go through parity-ethereum and all other projects that use the crate and make sure the necessary changes are made).
Until then I'll put this PR on ice.
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
koushiro
changed the title
|
Updated, PTAL again @dvdplm |
ordian
approved these changes
Jun 25, 2019
|
@dvdplm could you take a look again? |
dvdplm
reviewed
Jun 25, 2019
keccak-hash/src/lib.rs
Outdated
| use std::io; | ||
| use std::slice; | ||
| #[cfg(not(feature = "std"))] | ||
| extern crate alloc; |
There was a problem hiding this comment.
Doesn't use alloc; work here?
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
|
@debris can I spend a review coin here? :) |
dvdplm
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: koushiro koushiro.cqx@gmail.com
What have I changed
Add no_std support;
Migrate keccak-hash to 2018 edition;
related issue: #143