Keep multiple latest confirmed nonces at source in messages relay #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found this when working on #680
So there's lag before finalized source header
H
appear at target chain. Relay was readinglatest_confirmed_nonce_at_source
from best finalized source block. Then it has been using this value to compute number of headers that may fit into delivery transaction and was generating proof of this value at blockH'
, which is best finalized source block, known to target node. IfH != H'
, then the value may also be different => the target chain may have rejected some messages from delivery transaction. Relayer then had to wait forstall_timeout
to pass and only then continue its work.Another change is splitting single
target_nonces_updated
intobest_target_nonces_updated
andfinalized_target_nonces_updated
to maintain this new deque (latest_confirmed_nonces_at_source
).