Some relayer improvments #2902
Some relayer improvments #2902
Conversation
… + additional log
There was a problem hiding this comment.
I'll propagate changes to polkadot-sdk once paritytech/polkadot-sdk#3859 is merged.
I can cherry-pick this commit into paritytech/polkadot-sdk#3859 after it's merged into parity bridges-common or I can redo paritytech/polkadot-sdk#3859 from scratch. I see that there are some more comments to address there anyway, and I'll probably fix at least part of them inside parity-bridges-common
| /// Websocket server host name. | ||
| pub host: String, | ||
| /// Websocket server TCP port. | ||
| pub port: u16, | ||
| /// Websocket endpoint path at server. | ||
| pub path: Option<String>, |
There was a problem hiding this comment.
Should we mark host, port, path and secure as deprecated in order to not forget about them ?
There was a problem hiding this comment.
IMO there's no much point in deprecating this in code - it'll only propagate to multiple #[allow(deprecated)] attributes across the code and end-users (those who run relays) won't see it anyway. I've just tried to find something deprecation-related in the clap/structopt to deprecate arguments instead, but there's nothing for that. And I don't want to remove arguments right now, because we have several relayers running && it'll take some time to propagate this change there. I could add a suffix to associated CLI arguments: "Deprecated: use uri instead" as a compromise. WDYT?
There was a problem hiding this comment.
Ok, makes sense.
I could add a suffix to associated CLI arguments: "Deprecated: use uri instead" as a compromise. WDYT?
I don't know if it's necessary. We can leave it as it is. At most we can add a TODO comment, just to make sure we don't forget about it.
There was a problem hiding this comment.
I've filed #2909 to track it
* added CLI arguments: full WS URI + separate for WS path URI component + additional log * URI -> URL? * added TODO * fmt
* added CLI arguments: full WS URI + separate for WS path URI component + additional log * URI -> URL? * added TODO * fmt
I'll propagate changes to
polkadot-sdkonce paritytech/polkadot-sdk#3859 is merged.This PR just adds some CLI args that we haven't supported so far. E.g. to connect to OnFinality Polkadot node, you need to use
wss://polkadot.api.onfinality.io:443/public-ws. You had no chance to specify thatpathcomponent before this PR. Now you can use either:or
We'll deprecate the former method later, when we'll start using
*-uriin all our relayers.