Added generic DispatchLevelResult to the MessageDispatchResult #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
commented
Nov 30, 2022
svyatonik
reviewed
Nov 30, 2022
svyatonik
reviewed
Nov 30, 2022
primitives/runtime/src/messages.rs
Outdated
| @@ -22,7 +22,7 @@ use scale_info::TypeInfo; | |||
|
|
|||
| /// Message dispatch result. | |||
| #[derive(Encode, Decode, RuntimeDebug, Clone, PartialEq, Eq, TypeInfo)] | |||
| pub struct MessageDispatchResult { | |||
| pub struct MessageDispatchResult<DispatchLevelResult: Clone + Decode + sp_std::fmt::Debug + Eq> { | |||
There was a problem hiding this comment.
Can you also try NoBound versions here? :) I've found them recently && iiuc it should help with removing these constraints (maybe I'm wrong though)
There was a problem hiding this comment.
when I tried to change RuntimeDebug to RuntimeDebugNoBound I get this error:
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 6, 2023
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 9, 2023
This reverts commit b96b41c.
4 tasks
boundless-forest
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 12, 2023
* Anchor polkadot-v0.9.32 * fix parity-util-mem conflict * Anchor polkadot-v0.9.33 * Companion for paritytech/parity-bridges-common#1613 * Companion for paritytech/parity-bridges-common#1616 * Companion for paritytech/parity-bridges-common#1619 * Companion for paritytech/parity-bridges-common#1623 * Companion for paritytech/parity-bridges-common#1622 * Companion for paritytech/parity-bridges-common#1655 * Companion for paritytech/parity-bridges-common#1670 * Companion for paritytech/parity-bridges-common#1690 * Correct cargo * Revert "Companion for paritytech/parity-bridges-common#1690" This reverts commit 926b32d. * Revert "Companion for paritytech/parity-bridges-common#1670" This reverts commit b96b41c. * Fix compile * Revert "Companion for paritytech/parity-bridges-common#1622" This reverts commit 4c5865d. * Fix compile * format * Fix test * Fix dispatch test * Try fix compile with darwinia-2.0 * Revert "Try fix compile with darwinia-2.0" This reverts commit c9dcd67. * Update prepare branch * Format * Remove unused trait * Remove unused import
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 17, 2023
* Anchor polkadot-v0.9.32 * fix parity-util-mem conflict * Anchor polkadot-v0.9.33 * Companion for paritytech/parity-bridges-common#1613 * Companion for paritytech/parity-bridges-common#1616 * Companion for paritytech/parity-bridges-common#1619 * Companion for paritytech/parity-bridges-common#1623 * Companion for paritytech/parity-bridges-common#1622 * Companion for paritytech/parity-bridges-common#1655 * Companion for paritytech/parity-bridges-common#1670 * Companion for paritytech/parity-bridges-common#1690 * Correct cargo * Revert "Companion for paritytech/parity-bridges-common#1690" This reverts commit 926b32d. * Revert "Companion for paritytech/parity-bridges-common#1670" This reverts commit b96b41c. * Fix compile * Revert "Companion for paritytech/parity-bridges-common#1622" This reverts commit 4c5865d. * Fix compile * format * Fix test * Fix dispatch test * Try fix compile with darwinia-2.0 * Revert "Try fix compile with darwinia-2.0" This reverts commit c9dcd67. * Update prepare branch * Format * Remove unused trait * Remove unused import
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 17, 2023
…238) * Anchor polkadot-v0.9.32 * fix parity-util-mem conflict * Anchor polkadot-v0.9.33 * Companion for paritytech/parity-bridges-common#1613 * Companion for paritytech/parity-bridges-common#1616 * Companion for paritytech/parity-bridges-common#1619 * Companion for paritytech/parity-bridges-common#1623 * Companion for paritytech/parity-bridges-common#1622 * Companion for paritytech/parity-bridges-common#1655 * Companion for paritytech/parity-bridges-common#1670 * Companion for paritytech/parity-bridges-common#1690 * Correct cargo * Revert "Companion for paritytech/parity-bridges-common#1690" This reverts commit 926b32d. * Revert "Companion for paritytech/parity-bridges-common#1670" This reverts commit b96b41c. * Fix compile * Revert "Companion for paritytech/parity-bridges-common#1622" This reverts commit 4c5865d. * Fix compile * format * Fix test * Fix dispatch test * Try fix compile with darwinia-2.0 * Revert "Try fix compile with darwinia-2.0" This reverts commit c9dcd67. * Update prepare branch * Format * Remove unused trait * Remove unused import
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Apr 19, 2023
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…ytech#1670) * Added generic DispatchLevelResult to the MessageDispatchResult * Removed unnecessery `Clone + Decode + sp_std::fmt::Debug + Eq` + clippy
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…ytech#1670) * Added generic DispatchLevelResult to the MessageDispatchResult * Removed unnecessery `Clone + Decode + sp_std::fmt::Debug + Eq` + clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.