Switch to gav-xcm-v3 branch to be able to test bridges + XCMv3 integration #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
the
A-chores
svyatonik
commented
Apr 27, 2022
| @@ -144,7 +144,8 @@ test: | |||
| - time cargo fetch | |||
| - time cargo fetch --manifest-path=`cargo metadata --format-version=1 | jq --compact-output --raw-output ".packages[] | select(.name == \"polkadot-test-runtime\").manifest_path"` | |||
| - time cargo fetch --manifest-path=`cargo metadata --format-version=1 | jq --compact-output --raw-output ".packages[] | select(.name == \"polkadot-runtime\").manifest_path"` | |||
| - CARGO_NET_OFFLINE=true time cargo test --verbose --workspace | |||
| - time cargo fetch --manifest-path=`cargo metadata --format-version=1 | jq --compact-output --raw-output ".packages[] | select(.name == \"kusama-runtime\").manifest_path"` | |||
There was a problem hiding this comment.
Originally this cargo fetch has been added because we had problems with concurrent runtime builds (we build 6 now :/) and cargo metdata was called during build, which doesn't work well with concurrent builds. I've added SKIP_POLKADOT_RUNTIME_WASM_BUILD and etc because we don't need these runtimes in cargo test.
This reverts commit fc35ac6.
This was referenced Apr 27, 2022
acatangiu
approved these changes
Apr 28, 2022
Merged
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* add wss bootnodes to statemint chainspec * add wss bootnodes to statemine chainspec
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…ation (paritytech#1378) * switch to gav-xcm-v3 branch (wip) * add comment * play with CI * keep playing with CI * play with CI * trigger CI * Revert "trigger CI" This reverts commit fc35ac6.
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…ation (paritytech#1378) * switch to gav-xcm-v3 branch (wip) * add comment * play with CI * keep playing with CI * play with CI * trigger CI * Revert "trigger CI" This reverts commit fc35ac6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying first to jsut change all our references to
gav-xcm-v3Polkadot/Cumulus branch, but both Substrate and Polkadot crates are duplicated in this case, because Polkadot/Cumulus code still referencesmasterbranch. So solution is to patch references in the workspace'Cargo.tomltemporarily, until XCMv3 PR is merged.The goal of this PR is not to have working XCM on our chains, but to have code which we may start using for our experiments.