Unify error enums & generation #857
Labels
A-chores
Something that has to be done, as part of regular maintenance
Good First Issue
Good for newcomers
P-Relay
Milestone
Comments
tomusdrw
added
Good First Issue
This was referenced Apr 1, 2021
Merged
vmarkushin
added a commit
to vmarkushin/parity-bridges-common
that referenced
this issue
Jul 11, 2021
Related to paritytech#857 There are many String-typed errors that could be transformed to similar error enums, but since they only used once, I decided to not touch them and just change the existing ones (although, it could improve readability).
vmarkushin
added a commit
to vmarkushin/parity-bridges-common
that referenced
this issue
Aug 28, 2021
Related to paritytech#857 There are many String-typed errors that could be transformed to similar error enums, but since they only used once, I decided to not touch them and just change the existing ones (although, it could improve readability).
vmarkushin
added a commit
to vmarkushin/parity-bridges-common
that referenced
this issue
Oct 14, 2021
tomusdrw
pushed a commit
that referenced
this issue
Oct 22, 2021
tomusdrw
modified the milestones:
When Thou Have Spare Hour (2021),
When Thou Have Spare Hour
|
Assuming closed with #1094 |
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this issue
Mar 27, 2024
…aritytech#1094) * Unify error enums in substrate and ethereum clients with `thiserror` Related to paritytech#857 * Add license pre-amble * rustfmt * Fix spelling
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this issue
Apr 8, 2024
…aritytech#1094) * Unify error enums in substrate and ethereum clients with `thiserror` Related to paritytech#857 * Add license pre-amble * rustfmt * Fix spelling
bkchr
pushed a commit
to paritytech/polkadot-sdk
that referenced
this issue
Apr 10, 2024
…(#1094) * Unify error enums in substrate and ethereum clients with `thiserror` Related to paritytech/parity-bridges-common#857 * Add license pre-amble * rustfmt * Fix spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we mostly use manually implemented
Errorenums across the codebase. These enums do not necessarily implementstd::error::Errortrait, which is fine for runtime stuff, but would be useful for relayer code.The relayer code is using
Stringerrors though, cause we mostly don't care about anything specific, but need to propagate it up in the stack.Recently in #813
anyhowgot introduced and now with #849 there is even more error-specific refactorings being done.@adoerr suggested to use
anyhow / thiserrorcombo to unify error handling which I think is the right idea.Basically the rule is:
anyhowfor the last mile CLI stuff, where we really don't care about the error.thiserrorfor non-cli libraries that are used outside of the runtime to avoid manualDisplay/std::io::Errorimplementation.The text was updated successfully, but these errors were encountered: