Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CliChain abstraction #854

Closed
tomusdrw opened this issue Mar 31, 2021 · 1 comment
Closed

Fix CliChain abstraction #854

tomusdrw opened this issue Mar 31, 2021 · 1 comment
Labels
A-feat New feature or request P-Relay
Milestone
Nice To Have

Comments

@tomusdrw
Copy link
Contributor

Follow up of #849.

After the PR lands, CliChain trait includes things like type MessagePayload and fn encode_call/encode_message. The problem with this abstraction is that it's not generic enough (see #853), it only works cause currently we don't have a bridge which can send messages to two different target chains.

The goal is to fix this abstraction - most likely it's not CliChain responsibility at all I think this can be nicely generalised with the select_bridge macro and some structural code unification.
@tomusdrw tomusdrw added this to the Rococo<>Westend Testnet milestone Mar 31, 2021
This was referenced Apr 1, 2021
Closed
Merged
@svyatonik
Copy link
Contributor

Irrelevant

svyatonik pushed a commit that referenced this issue Jul 17, 2023
@bkchr
Fix benchmarks and ensure CI tests them (#854)
e3a1e39 
* Fix benchmarks and ensure CI tests them

* FMT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-feat New feature or request P-Relay
Projects
None yet
Milestone
Nice To Have
Development

No branches or pull requests
2 participants
@tomusdrw @svyatonik