Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): log connections properly #929

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

niklasad1
Copy link
Member

This PR fixes that the connection count is read before the connection has attempted to converted in a HTTP connection which may cause the log is updated when that occurs.

In addition I refactored the connection task to separate function such that all occurs in the same connection tracing span.

This PR fixes that the connection count is read after a connection has been accepted and
not before which cause this log to be out of order.
@niklasad1 niklasad1 requested a review from a team as a code owner November 4, 2022 14:37
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test seems to fail because of the change in compile UI tests

note: required for `<Conf as Config>::Hash` to implement `DeserializeOwned`

to

note: required because of the requirements on the impl of `DeserializeOwned` for `<Conf as Config>::Hash`

I think we could just restart the test with TRYBUILD=overwrite

@niklasad1
Copy link
Member Author

niklasad1 commented Nov 7, 2022

@lexnv

The test seems to fail because of the change in compile UI tests

That's just because the gitlab CI is using an old rustc version, I updated it to work with the latest rustc version
So I'm just going to ignore that for now :)

@niklasad1 niklasad1 merged commit 1f6368d into master Nov 7, 2022
@niklasad1 niklasad1 deleted the na-fix-bad-accept-conn-log branch November 7, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants