Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rpc module): don't send messages when client is gone #724

Merged

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Apr 4, 2022

We introduced some server side messages when a subscription is closed.

However, those were only intended to be sent when the server closed down subscription and currently if the connection was terminated by the client or unsubscribed by the client those were sent anyway which causes the server to send one extra message per subscription.

Such that if many subscriptions per connection it will slow down it might slow down the server significantly.

@niklasad1 niklasad1 requested a review from a team as a code owner April 4, 2022 23:16
@niklasad1 niklasad1 changed the title perf: don't send messages when client is gone perf(rpc module): don't send messages when client is gone Apr 4, 2022
@niklasad1 niklasad1 merged commit fe53e5c into master Apr 5, 2022
@niklasad1 niklasad1 deleted the ws-server-dont-send-responses-to-sub-already-closed branch April 5, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants