Update soketto requirement from 0.6 to 0.7 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [soketto](https://github.com/paritytech/soketto) to permit the latest version. - [Release notes](https://github.com/paritytech/soketto/releases) - [Changelog](https://github.com/paritytech/soketto/blob/develop/CHANGELOG.md) - [Commits](paritytech/soketto@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: soketto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dvdplm
previously approved these changes
Sep 30, 2021
maciejhirsz
approved these changes
Oct 1, 2021
dvdplm
approved these changes
Oct 1, 2021
Comment on lines
+239
to
+245
| let mut headers: ArrayVec<Header, 1> = ArrayVec::new(); | ||
|
|
||
| if let Some(origin) = self.origin_header.as_ref() { | ||
| client.set_origin(origin); | ||
| headers.push(Header { name: "Origin", value: origin.as_bytes() }); | ||
| } | ||
|
|
||
| client.set_headers(&headers); |
There was a problem hiding this comment.
dq: why not do all this inside the if let Some(origin)… clause?
There was a problem hiding this comment.
headers have to be defined outside of the if block to satisfy lifetimes, and it seemed more natural to me to set headers on the same scope they are defined.
There was a problem hiding this comment.
@maciejhirsz I did it slightly different in #397 but this is quite neat not re-export Header from this library but I did it with an array instead. So not sure why ArrayVec dep is needed but maybe I did some refactoring with the redirect loop to make it work not sure.
let origin = self.origin_header.map(|o| [o]);
let client = some_code();
if let Some(o) = origin {
client.set_headers(o);
}
...
There was a problem hiding this comment.
ah I see now, origin is borrowed in the header and ☝️ won't work.
niklasad1
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on soketto to permit the latest version.
Release notes
Sourced from soketto's releases.
Changelog
Sourced from soketto's changelog.
... (truncated)
Commits
feb2204Release v0.7.0 (#51)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)