[ws client]: parse path from the URL
#335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes that the path/HTTP resource path is parsed from the URL and removes that option from WsClientBuilder.
niklasad1
commented
May 24, 2021
| /// Sets the URL to pass during the HTTP handshake. | ||
| /// | ||
| /// The default URL is `/`. | ||
| pub fn with_handshake_url(mut self, url: impl Into<Cow<'a, str>>) -> Self { |
niklasad1
commented
May 24, 2021
| @@ -175,8 +175,7 @@ pub struct WsClientBuilder<'a> { | |||
| max_request_body_size: u32, | |||
| request_timeout: Option<Duration>, | |||
| connection_timeout: Duration, | |||
| origin: Option<Cow<'a, str>>, | |||
| handshake_url: Cow<'a, str>, | |||
There was a problem hiding this comment.
removed this and parses it from the URL instead
niklasad1
commented
May 24, 2021
| @@ -210,8 +208,8 @@ impl<'a> WsClientBuilder<'a> { | |||
| } | |||
|
|
|||
| /// Set request timeout. | |||
| pub fn request_timeout(mut self, timeout: Option<Duration>) -> Self { | |||
There was a problem hiding this comment.
annoying builder method; unrelated to this PR
niklasad1
commented
May 24, 2021
| @@ -210,8 +208,8 @@ impl<'a> WsClientBuilder<'a> { | |||
| } | |||
|
|
|||
| /// Set request timeout. | |||
| pub fn request_timeout(mut self, timeout: Option<Duration>) -> Self { | |||
| self.request_timeout = timeout; | |||
| pub fn request_timeout(mut self, timeout: Duration) -> Self { | |||
There was a problem hiding this comment.
annoying builder method; unrelated to this PR
|
I tested the fix and that's a PASS for me. |
dvdplm
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #306
This commit changes that the path/HTTP resource path is parsed from the URL and removes that option
from WsClientBuilder.