Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RpcModule::remove #1416

Merged
merged 2 commits into from
Jun 26, 2024
Merged

add RpcModule::remove #1416

merged 2 commits into from
Jun 26, 2024

Conversation

polachok
Copy link
Contributor

Currently it's not possible to remove or replace a method. This is useful for overriding methods from an RpcModule with manual implementation or another module.

@polachok polachok requested a review from a team as a code owner June 21, 2024 14:41
@niklasad1 niklasad1 changed the title rpc: remove method add RpcModule::remove Jun 21, 2024
@niklasad1 niklasad1 changed the title add RpcModule::remove add RpcModule/Method::remove Jun 21, 2024
@niklasad1 niklasad1 self-requested a review June 21, 2024 15:15
@niklasad1 niklasad1 requested a review from jsdw June 21, 2024 19:01
jsdw
jsdw reviewed Jun 24, 2024
View reviewed changes
core/src/server/rpc_module.rs Outdated Show resolved Hide resolved
@niklasad1 niklasad1 changed the title add RpcModule/Method::remove add RpcModule::remove Jun 26, 2024
@niklasad1 niklasad1 merged commit 9ebc4c1 into paritytech:master Jun 26, 2024
10 checks passed
niklasad1 added a commit that referenced this pull request Jun 26, 2024
@polachok @niklasad1
add RpcModule::remove (#1416)
b7d601f 
* rpc: remove method

* remove internal remove method

---------

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
@prestwich prestwich mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polachok @jsdw @niklasad1