fix: remove sockaddrs field from Target
#1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
force-pushed
the
fix/do-not-resolve-ips-on-build-with-stream
branch
3 times, most recently
from
4c21cf4
to
fcf3da2
Compare
oleonardolima
commented
Jun 19, 2024
oleonardolima
changed the title
TargetTarget
- remove the `sockaddrs` field from `Target`. - resolve the `sockaddrs` only in `try_connect_over_tcp`, the only place it's required. - do not resolved `sockaddrs` on `build_with_stream`.
oleonardolima
force-pushed
the
fix/do-not-resolve-ips-on-build-with-stream
branch
from
fcf3da2
to
dd0bec4
Compare
I was thinking about how to prevent regressions on this (as it could "leak" connection data), and I'll try to create a test for it in a new commit, then it should be ready to go. |
|
@oleonardolima are you happy with this PR without the extra tests you mentioned? |
Yes, I can add it later in another PR. |
niklasad1
pushed a commit
that referenced
this pull request
Jun 26, 2024
- remove the `sockaddrs` field from `Target`. - resolve the `sockaddrs` only in `try_connect_over_tcp`, the only place it's required. - do not resolved `sockaddrs` on `build_with_stream`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1411