refactor: use rustls-platform-verifier cert store #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
May 21, 2024
| @@ -522,16 +522,6 @@ impl<T: Clone> RequestIdGuard<T> { | |||
| } | |||
| } | |||
|
|
|||
| /// What certificate store to use | |||
There was a problem hiding this comment.
removed this from here because I don't want to expose another feature flag for TLS stuff
jsdw
reviewed
May 24, 2024
client/http-client/Cargo.toml
Outdated
| default = ["native-tls"] | ||
| native-tls = ["hyper-rustls/native-tokio", "hyper-rustls/ring", "__tls"] | ||
| webpki-tls = ["hyper-rustls/webpki-tokio", "hyper-rustls/ring", "__tls"] | ||
| default = ["tls"] | ||
|
|
||
| # Internal feature to indicate whether TLS is enabled. |
There was a problem hiding this comment.
Not internal any more then? :)
There was a problem hiding this comment.
We had two feature flags for tls (native-tls, webpki-tls) before which was public but we don't need them anymore because we only support rustls-platform-verifier and the internal feature flag is not needed anymore
There was a problem hiding this comment.
ah ok, I guess you were referring to the outdated comment, removed now
jsdw
reviewed
May 24, 2024
jsdw
reviewed
May 24, 2024
jsdw
reviewed
May 24, 2024
jsdw
approved these changes
May 24, 2024
niklasad1
commented
May 24, 2024
niklasad1
commented
May 24, 2024
The builder fns in this PR should be sufficient :) |
lexnv
approved these changes
May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1340
This PR replaces the current certificate stores
rust-native-certandwebpkiwithrustls-platform-verifierand additionally it adds an API to use a custom certificate store for special use-cases e.g. such as disabling cert verification or use some custom certificate store on some niche platform.