Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow application/json-rpc http content type #1277

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

dan-starkware
Copy link
Contributor

Hi, consider allowing 'application/json-rpc' content type.

I came across this (deprecated?) JSON-RPC over HTTP specification file that indicates that content-type should be 'application/json-rpc'.
Also, several widely used libraries, such as jsonrpc4j use it.

@dan-starkware dan-starkware requested a review from a team as a code owner January 18, 2024 11:46
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I see no problem by supporting these content types.

The assumption from our side is that "application/json" is mainly used for JSON-RPC v2 but it's not really specified there.

Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@niklasad1 niklasad1 merged commit ae9e612 into paritytech:master Jan 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants