fix(server): fix leak in FuturesUnordered #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tokio::spawn handles were never removed from `FutursUnordered` which this commit fixes. Reduces the memory usage signficantly but still slightly worse than v0.16.x
jsdw
approved these changes
Sep 15, 2023
niklasad1
commented
Sep 15, 2023
lexnv
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FuturesUnordered was not getting polled until shutdown, so it was accumulating tasks forever. The change uses a channel instead to wait until all senders are closed before shutdown can happen.
Reduces the memory usage significantly but still slightly worse than v0.16.x, around 2x but that should be okay.
Close #1200