Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release v0.19.0 #1155

Merged
merged 7 commits into from
Jul 22, 2023
Merged

chore: Release v0.19.0 #1155

merged 7 commits into from
Jul 22, 2023

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Jul 20, 2023

[v0.19.0] - 2023-07-20

[Fixed]

  • Fixed connections processing await on server shutdown (#1153)
  • fix: include error code in RpcLogger (#1135)
  • fix: downgrade more logs to debug (#1127)
  • fix(server): remove MethodSinkPermit to fix backpressure issue on concurrent subscriptions (#1126)
  • fix readme links (#1152)

[Changed]

  • server: downgrade connection logs to debug (#1123)
  • refactor(server): make Server::start infallible and add fn builder() (#1137)

[Added]

  • added uptest new rust lib (#1151)
  • Add subway (#1124)
  • Add Trin to users and sort list alphabetically (#1119)

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv requested a review from a team as a code owner July 20, 2023 15:22
@lexnv lexnv self-assigned this Jul 20, 2023
@jsdw
Copy link
Collaborator

jsdw commented Jul 20, 2023

I think the "make Server::start infallible and add fn builder()" is a breaking change isn't it, so we can't just bump the patch version here right?

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv changed the title chore: Release v0.18.3 chore: Release v0.19.0 Jul 20, 2023
CHANGELOG.md Outdated
### [Added]

- added uptest new rust lib ([#1151](https://github.com/paritytech/jsonrpsee/pull/1151))
- Add subway ([#1124](https://github.com/paritytech/jsonrpsee/pull/1124))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this isn't really important (and should prolly be "Add Subway to users list"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that makes sense, will remove this since I'd place it with the same priority as chore PRs 👍

Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsdw
Copy link
Collaborator

jsdw commented Jul 20, 2023

Revert "tests: Change expected error to accomodate rust from gitlab"

Hehe I suspected this might be the case; same happened in another recent PR :) Best to work with latest rust and we can ignore gitlab for now until it's updated if need be!

@lexnv
Copy link
Contributor Author

lexnv commented Jul 20, 2023

Yep exactly! Wanted to confirm that the commit tests: Change expected error to accomodate rust from gitlab will solve the issue for the gitlab runner, that to fallback to our github one.

That was just to make sure we can continue with this PR while progress is being made on the CI/CD side

@niklasad1
Copy link
Member

fix(server): remove MethodSinkPermit to fix backpressure issue on concurrent subscriptions (#1126)

is also a breaking change so good call making this v0.19

@niklasad1 niklasad1 merged commit 96c035c into master Jul 22, 2023
8 checks passed
@niklasad1 niklasad1 deleted the lexnv/release-v0.18.3 branch July 22, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants