Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message on subscription limit #775

Closed
nazar-pc opened this issue May 18, 2022 · 1 comment
Closed

Better error message on subscription limit #775

nazar-pc opened this issue May 18, 2022 · 1 comment

Comments

@nazar-pc
Copy link

As discovered in paritytech/substrate#11460, when the limit of subscriptions is reached following error is returned to the client:

RPC call failed: ErrorObject { code: ServerError(-32604), message: "Server is busy, try again later", data: None }

The error isn't very descriptive, it took be a bit of time to figure out what resource was actually exceeded from error code. Something like "Reached limit for number of connections" would have saved me some time.
niklasad1 added a commit that referenced this issue Jun 5, 2022
@niklasad1
fix(servers): more descriptive errors calls fail
d6afe8c 
Closing #775
@niklasad1 niklasad1 mentioned this issue Jun 5, 2022
Merged
niklasad1 added a commit that referenced this issue Jun 13, 2022
@niklasad1
fix(servers): more descriptive errors when calls fail (#790)
5a344c0 
* fix(servers): more descriptive errors calls fail

Closing #775

* fix tests

* rename constants

* address grumbles
@niklasad1
Copy link
Member

Fixed by #790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nazar-pc @niklasad1