src/lib: Make raise_fd_limit return new limit #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
force-pushed
the
return-new-limit
branch
from
58cea29
to
522d7ec
Compare
Add return value `Option<u64>` to `raise_fd_limit` returning the new file descriptor limit to the caller.
mxinden
force-pushed
the
return-new-limit
branch
from
522d7ec
to
e59cd0d
Compare
|
Concrete use case described in paritytech/substrate#6956. |
|
@NikVolf do you have some time to review this pull request? |
NikVolf
approved these changes
Aug 27, 2020
|
@NikVolf thanks for publishing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add return value
Option<u64>toraise_fd_limitreturning the new file descriptor limit to the caller.I am not able to test this on a MacOS or iOS machine.
cargo build --target x86_64-apple-darwincompiles. Could someone with a Mac test this?As far as I can tell
rlimit::rlim_curis au64on both 64 bit OS and 32 bit OS. Please correct me if I am wrong.cargo build --target i686-unknown-linux-muslsucceeds.Patch bumps the crate's version to
v0.2.0for a new release.