-
Notifications
You must be signed in to change notification settings - Fork 380
New weights #951
New weights #951
Conversation
…ulus into release-parachains-v7.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that due to the recent DB cache size increase (128 -> 1024) many of these drift quite a bit, usually downwards
I've only highlighted some of the bigger changes - the recent DB cache size change has improved perf and thus lowered the weights across the board (i think?) |
This change will not affect the weights you are pointing out at all. |
hmm, well we could rerun and check that the results are stable and it is not an aberration. Do we know of any PRs that should dramatically improved things? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems in line changes in general. As long as we are ok with 0 weight for remarks then looks reasonable. (remark_with_event is already 0 weighted)
just FYI: the Substrate weights went down when running the benchmarks with optimizations: paritytech/substrate#10692 |
No description provided.