This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
pov-recovery: Enable pov-recovery as well on full nodes #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pov recovery was before only enabled for collators. The reason behind this was prevention of spam of the relay chain for block recovery. However, recent events has shown that this wasn't a good idea. So, this pr enables pov-recover for normal full nodes as well, but with a much higher delay before trying to recover a block. This means that full nodes will wait in minimum 2.5 minutes and in maximum 5 minutes before recovering a block. This should give collators in "normal mode" enough time to recover a block (they wait in maximum 6 seconds after they have seen a new candidate in the relay chain) before recovering a block. So, we should hopefully not spam the relay chain.
This was referenced Jan 21, 2022
|
Looks good. Only thing is that the comment here should be adjusted to reflect this change: https://github.com/paritytech/cumulus/blob/master/client/pov-recovery/src/lib.rs#L27 |
skunert
approved these changes
Jan 21, 2022
26 tasks
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pov recovery was before only enabled for collators. The reason behind this was prevention of spam of
the relay chain for block recovery. However, recent events has shown that this wasn't a good idea.
So, this pr enables pov-recover for normal full nodes as well, but with a much higher delay before
trying to recover a block. This means that full nodes will wait in minimum 2.5 minutes and in
maximum 5 minutes before recovering a block. This should give collators in "normal mode" enough time
to recover a block (they wait in maximum 6 seconds after they have seen a new candidate in the relay
chain) before recovering a block. So, we should hopefully not spam the relay chain.