This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Ensure bad datastream cannot cause problems2 #888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
A0-pleasereview
B0-silent
|
Yes it is guaranteed to always consume the input, otherwise it would not have decoded anything. |
|
Maybe you could just read the docs of scale codec? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is
decode_and_advance_with_depth_limitguaranteed to always consume some of the input? I feel like we should do the same as #701 and add a guard and fail if the buffer was not reduced in size to be on the safe side (or failing that make it clear in the doc of that function that it must uphold that invariant).(
if lethas been turned into amatchand guardif remaining_fragments.len() < last_remaining_fragments.len()added.)