Add Bridges to `xcm-emulator` #2812

NachoPal · 2023-07-03T10:34:52Z

Adding bridging capabilities to xcm-emulator.

The bridge that a Network is expecting is any type that implements the BridgeMessageHandler trait. In this way we decouple xcm-emulator from the particular Bridge implementation for BridgeHub, avoiding also the need of importing all related packages (bp_messages, pallet_bridge_messages, etc). In addition, this approach would allow other teams to add their own Bridge implementations to the Network.

The BridgeHub transport layer has been mocked, abstracting out all the unnecessary complexity related to Relayers and proofs.

In the PR have been added other improvements:

More logs (dmp, ump and hrmp)
Network trait refactoring
decl_test_sender_receiver_accounts_parameter_types macro

NachoPal · 2023-07-03T11:03:41Z

bot fmt

command-bot · 2023-07-03T11:03:46Z

@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108369 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 11-5de37e9a-619e-422f-bb81-7e44ee31817a to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-07-03T11:04:25Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108369 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108369/artifacts/download.

NachoPal · 2023-07-03T11:19:08Z

bot fmt

command-bot · 2023-07-03T11:19:12Z

@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108705 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 12-1cc863b0-0535-44fa-b3c0-e383c5907eaf to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-07-03T11:19:52Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108705 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108705/artifacts/download.

NachoPal · 2023-07-03T11:32:44Z

bot fmt

command-bot · 2023-07-03T11:32:48Z

@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108859 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-3d2c3f53-d6f3-4fe4-96bf-e604627abbe7 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-07-03T11:33:27Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108859 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3108859/artifacts/download.

bkontur · 2023-07-03T13:29:33Z

bridges/primitives/messages/src/lib.rs

@@ -102,6 +102,18 @@ impl TypeId for LaneId {
 	const TYPE_ID: [u8; 4] = *b"blan";
 }

+impl From<LaneId> for u32 {


@NachoPal @svyatonik
I am not sure about this, can we move this out of bridges substree?
Because then we need to backport it back to bridges repo and also in new version LaneId has a different type: https://github.com/paritytech/parity-bridges-common/pull/2221/files#diff-836b204328629e6af4b33c2a34ae41191cab06cf89c066e31bdb7085314fcda1L185-R203

Agreed there's probably a better way to do this.

The problem is implementing From for LaneId or the fact that LaneId is going to change? I do not think it is harmful to implement an extra From for a new type.

I could try to locally (as part of the BridgeHubMessageHandler impl) wrap LaneId in a new type and implement the From trait for it.

I could try to locally (as part of the BridgeHubMessageHandler impl) wrap LaneId in a new type and implement the From trait for it.

@bkontur @gilescope Check it out

xcm/xcm-emulator/src/lib.rs

Co-authored-by: Squirrel <gilescope@gmail.com>

This reverts commit 92e8f20.

NachoPal · 2023-07-04T14:18:25Z

bot fmt

command-bot · 2023-07-04T14:18:30Z

@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3122354 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-0858910d-7e97-4473-bd78-6e98b7652165 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-07-04T14:19:42Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3122354 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3122354/artifacts/download.

NachoPal · 2023-07-05T09:39:00Z

bot merge

NachoPal added 21 commits June 22, 2023 15:23

rename bridge hub + BridgeMessages type

832ea95

bridge base

2e1e065

bridge string approach

5d8dda1

add decl_test_bridges macro

ee1a0d2

outbound lanes on the way

0714c47

get & dispatch mock bridge done

7e22c13

fix bridge errors + log::debug for messages

ab15f33

clean up

1c71eb4

update source OutboundLaneData

ea9606f

rococo & wococo added

a478ae6

sender_receiver_accounts_parameter_types macro

d53b674

sender_receiver_accounts_parameter_types macro 2

281f5a5

fixed multi parachain + example on the way

1463d22

working but router error

d39deeb

bridge working

6e91b96

refactor NetworkComponent

97bb46a

make it generic

e9d3a07

working as generic

b0cbf79

clean up

4ea717b

last bit

7ca9ecb

merge master

8e645b7

paritytech-ci requested a review from a team July 3, 2023 10:35

NachoPal added B0-silent Changes should not be mentioned in any release notes T7-system_parachains This PR/Issue is related to System Parachains. A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. labels Jul 3, 2023

NachoPal requested review from gilescope and bkontur July 3, 2023 11:02

NachoPal added 2 commits July 3, 2023 13:14

fix bridge hub handler name

f9675bc

fix conflict

0dbb673

".git/.scripts/commands/fmt/fmt.sh"

d0d6eb2

bkontur reviewed Jul 3, 2023

View reviewed changes

paritytech-ci requested a review from a team July 3, 2023 13:29

add AssetConversion back for AssetHubWestend

5830ec2

gilescope reviewed Jul 4, 2023

View reviewed changes

xcm/xcm-emulator/src/lib.rs Outdated Show resolved Hide resolved

gilescope approved these changes Jul 4, 2023

View reviewed changes

NachoPal and others added 6 commits July 4, 2023 11:06

Update xcm/xcm-emulator/src/lib.rs

52281b5

Co-authored-by: Squirrel <gilescope@gmail.com>

add LaneId wrapper

4cd02c5

update substrate

92e8f20

fix wrapper conversion

82c20a9

remove duplicate in workspace

17c0612

Revert "update substrate"

e9ff40d

This reverts commit 92e8f20.

".git/.scripts/commands/fmt/fmt.sh"

1f9bc13

paritytech-processbot bot merged commit bf07cd8 into master Jul 5, 2023
4 checks passed

paritytech-processbot bot deleted the nacho/xcm-emulator-bridges-support-rococo branch July 5, 2023 09:39

crystalin mentioned this pull request Oct 20, 2023

Update substrate/polkadot/cumulus from v0.9.43 to v1.1.0 moonbeam-foundation/moonbeam#2535

Closed

JesseAbram mentioned this pull request Oct 26, 2023

Update substrate and subxt entropyxyz/entropy-core#435

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bridges to `xcm-emulator` #2812

Add Bridges to `xcm-emulator` #2812

NachoPal commented Jul 3, 2023 •

edited

Loading

NachoPal commented Jul 3, 2023

command-bot bot commented Jul 3, 2023 •

edited

Loading

command-bot bot commented Jul 3, 2023

NachoPal commented Jul 3, 2023

command-bot bot commented Jul 3, 2023 •

edited

Loading

command-bot bot commented Jul 3, 2023

NachoPal commented Jul 3, 2023

command-bot bot commented Jul 3, 2023 •

edited

Loading

command-bot bot commented Jul 3, 2023

bkontur Jul 3, 2023

gilescope Jul 4, 2023

NachoPal Jul 4, 2023 •

edited

Loading

NachoPal Jul 4, 2023

NachoPal commented Jul 4, 2023

command-bot bot commented Jul 4, 2023 •

edited

Loading

command-bot bot commented Jul 4, 2023

NachoPal commented Jul 5, 2023

Add Bridges to xcm-emulator #2812

Add Bridges to xcm-emulator #2812

Conversation

NachoPal commented Jul 3, 2023 • edited Loading

NachoPal commented Jul 3, 2023

command-bot bot commented Jul 3, 2023 • edited Loading

command-bot bot commented Jul 3, 2023

NachoPal commented Jul 3, 2023

command-bot bot commented Jul 3, 2023 • edited Loading

command-bot bot commented Jul 3, 2023

NachoPal commented Jul 3, 2023

command-bot bot commented Jul 3, 2023 • edited Loading

command-bot bot commented Jul 3, 2023

bkontur Jul 3, 2023

Choose a reason for hiding this comment

gilescope Jul 4, 2023

Choose a reason for hiding this comment

NachoPal Jul 4, 2023 • edited Loading

Choose a reason for hiding this comment

NachoPal Jul 4, 2023

Choose a reason for hiding this comment

NachoPal commented Jul 4, 2023

command-bot bot commented Jul 4, 2023 • edited Loading

command-bot bot commented Jul 4, 2023

NachoPal commented Jul 5, 2023

Add Bridges to `xcm-emulator` #2812

Add Bridges to `xcm-emulator` #2812

NachoPal commented Jul 3, 2023 •

edited

Loading

command-bot bot commented Jul 3, 2023 •

edited

Loading

command-bot bot commented Jul 3, 2023 •

edited

Loading

command-bot bot commented Jul 3, 2023 •

edited

Loading

NachoPal Jul 4, 2023 •

edited

Loading

command-bot bot commented Jul 4, 2023 •

edited

Loading