-
Notifications
You must be signed in to change notification settings - Fork 380
Companion for substrate#14435 (BenchmarkHelper for frame-system) #2766
Conversation
bot bench $ pallet asset-hub-kusama assets frame_system |
@bkontur Command was rescheduled and failed to finish (check for task id 1-c2ca62d5-4832-4d08-a05d-260546f9b709 in the logs); execution will not automatically be restarted further. |
bot bench $ pallet asset-hub-kusama assets frame_system |
@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3044226 was started for your command Comment |
@bkontur Command |
<ValidationData<T>>::put(&vfp); | ||
|
||
// insert dummy HostConfiguration with | ||
let host_config = AbridgedHostConfiguration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting all values here to zero may lead to unexpected behavior in the benchmark, if e.g. set_validation_data
is called within the benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thank you, changed to non-zero values
Waiting for commit status. |
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-43/3158/4 |
@bkontur could we backport this PR to |
paritytech/substrate#14435
Relates to: #2765 (comment)